Skip to content

WIP: impl a streaming writer temporary file storage abstraction #2175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: impl a streaming writer temporary file storage abstraction #2175

wants to merge 1 commit into from

Conversation

mengpromax
Copy link
Contributor

PR Details

impl a streaming writer temporary file storage abstraction to support custom temporary file storage.

Description

  1. replace streamingWriter.rawData with a interface.
  2. add a chunk size field to buffered writer which is default to 16MB or can be set by user.

Related Issue

  1. This will close StreamChunkSize(16MB) variable setting function #1927, will support buffered writer custom chunk size.

Motivation and Context

This issue #1927 inspire me.

How Has This Been Tested

  1. pass all exist UT.
  2. add custom temporary file storage UT.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

refactor: replace StreamWriter.rawData with a TepFile abstraction to …
01b1854 
…support more storage

Change-Id: Ibaca66b80a3ed8793396e1386bf7c0b2db7c21c0
Signed-off-by: mengzhongyuan <[email protected]>
@mengpromax mengpromax force-pushed the feat/rawDataAbstraction branch from d46c7b5 to 01b1854 Compare July 11, 2025 15:31
@xuri xuri added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StreamChunkSize(16MB) variable setting function
2 participants
@mengpromax @xuri